| From: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
|---|---|
| To: | Harshal Dhumal <harshal(dot)dhumal(at)enterprisedb(dot)com> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: Change server password [pgadmin4] |
| Date: | 2016-05-12 10:44:48 |
| Message-ID: | CANxoLDdq2eW5e+ankFAT4gkCv0P+5v7V9yVmDs74zcu+rOmWzw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi Harshal
Below are my review comments :
- Facing error unexpected identifier 'change_password: function(args)'
in js file.
- Please correct the spelling of password in the menu item.
- Title for alertify dialog showing "Change password for servers" it
should be only "Change Password" or "Change Password for <server name>".
- Facing error "name 'decrypt' is not defined."
- Not able to change the password facing error.
On Thu, May 12, 2016 at 1:43 PM, Harshal Dhumal <
harshal(dot)dhumal(at)enterprisedb(dot)com> wrote:
> Hi,
>
> PFA updated patch.
>
> --
> *Harshal Dhumal*
> *Software Engineer *
>
>
>
> EenterpriseDB <http://www.enterprisedb.com>
>
> On Thu, May 12, 2016 at 1:27 PM, Harshal Dhumal <
> harshal(dot)dhumal(at)enterprisedb(dot)com> wrote:
>
>> Hi,
>> This patch needs a rebase. (as "Named restore point" patch is committed.)
>>
>> --
>> *Harshal Dhumal*
>> *Software Engineer *
>>
>>
>>
>> EenterpriseDB <http://www.enterprisedb.com>
>>
>> On Wed, May 11, 2016 at 12:35 PM, Harshal Dhumal <
>> harshal(dot)dhumal(at)enterprisedb(dot)com> wrote:
>>
>>> Hi,
>>>
>>> PFA patch for changing server password.
>>>
>>>
>>> --
>>> *Harshal Dhumal*
>>> *Software Engineer *
>>>
>>>
>>>
>>> EenterpriseDB <http://www.enterprisedb.com>
>>>
>>
>>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>
--
*Akshay Joshi*
*Principal Software Engineer *
*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ashesh Vashi | 2016-05-12 10:46:25 | Re: Change server password [pgadmin4] |
| Previous Message | Ashesh Vashi | 2016-05-12 10:44:26 | pgAdmin 4 commit: Destroy the existing Select2 object before rerenderin |