| From: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
|---|---|
| To: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | [pgAdmin4][Patch]: RM #3607 Edit Data: Not able to remove filter SQL condition |
| Date: | 2018-09-11 09:12:45 |
| Message-ID: | CANxoLDdnCfiBL8nSDGAOOu1pC5OmZK0gER88Mxp6+oxaR1edtw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi Hackers,
Attached is the patch to fix the following for filter dialog:
- OK button should be disabled for Filter dialog when filter string is
empty. Filter dialog should be opened using context menu View Data ->
Filtered Rows or shortcut toolbar.
- On validation error dialog should not be closed.
- User should be able to clear the filter string from the Query Tool.
- Validation error should be thrown when filter dialog opened from Query
Tool and provide some wrong filter string.
Please review it.
--
*Akshay Joshi*
*Sr. Software Architect *
*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
| Attachment | Content-Type | Size |
|---|---|---|
| RM_3607.patch | application/octet-stream | 6.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dave Page | 2018-09-11 11:56:18 | pgAdmin 4 commit: Ensure auto-complete works for objects in schemas oth |
| Previous Message | Akshay Joshi | 2018-09-11 06:21:24 | Re: [pgAdmin4][Patch]: RM #3630 Autocomplete broken in v3.3 release, works in v3.2 |