Re: [GSoC] Support editing resultsets from tables with OIDs

Thanks patch applied.

On Mon, Jul 29, 2019 at 11:12 AM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:

>
> On Fri, Jul 26, 2019 at 5:33 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>> Akshay; can you take a look at this and commit if appropriate please? I'm
>> somewhat busy at the moment :-(
>>
>
> Sure, I am looking it.
>
>>
>> On the subject of the regression test - I assume at one point the
>> messages window was including the command tags in it's output. This failure
>> would indicate we broken that. Anyone got any ideas how that happened?
>>
>> On Thu, Jul 25, 2019 at 1:01 PM Yosry Muhammad <yosrym93(at)gmail(dot)com>
>> wrote:
>>
>>> Hi,
>>> Please find a patch attached to add supporting of resultsets from tables
>>> with OIDs as updatable resultsets (with updated test cases and docs) - this
>>> is a part of a GSoC project. Please review !
>>> This patch also includes a small refactor of the previous patch and a
>>> small bug fix that occurred when the query resultset had no rows but was
>>> updatable (row additions were not permitted, although they should be).
>>>
>>>
>>> On a different note, one of the feature tests fails (on master),
>>> probably due to a small typo. In query_tool_tests.py this function call:
>>>
>>> self.page.find_by_xpath(
>>> '//div[contains(@class, "sql-editor-message") and '
>>> 'contains(string(), "CREATE TABLE")]'
>>> )
>>>
>>> on lines 371-374 produces an exception that the element cannot be found,
>>> this is probably due to the fact that the message returned by the query
>>> executed before this call does not contain the string "CREATE TABLE". Just
>>> letting you know about this.
>>>
>>> Thanks and regards!
>>> --
>>>
>>> *Yosry Muhammad Yosry*
>>>
>>> Computer Engineering student,
>>> The Faculty of Engineering,
>>> Cairo University (2021).
>>> Class representative of CMP 2021.
>>> https://www.linkedin.com/in/yosrym93/
>>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
>
> *Sr. Software Architect*
> *EnterpriseDB Software India Private Limited*
> *Mobile: +91 976-788-8246*
>

--
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*