Re: [pgAdmin][RM4842] trigger/compound trigger on a partitioned table

From: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
To: Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin][RM4842] trigger/compound trigger on a partitioned table
Date: 2020-01-01 07:42:44
Message-ID: CANxoLDdkGdRN8+RH=APakr9qxDvQ5DOoEai3hA=bSkYW_g5v=w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Aditya

I have removed the generated folder and it works. Thanks, patch applied.

On Wed, Jan 1, 2020 at 11:58 AM Aditya Toshniwal <
aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:

> Hi Akshay,
>
> On Tue, Dec 31, 2019 at 1:28 PM Akshay Joshi <
> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>
>> Hi Aditya
>>
>> I have applied the patch and found one issue collection nodes are visible
>> twice under the child node of the partition table. Please fix that.
>>
> I tried to simulate this. But I'm not facing issue. Can you please verify
> once again ?
>
>> [image: Screenshot 2019-12-31 at 1.24.26 PM.png]
>>
>> On Wed, Dec 25, 2019 at 4:59 PM Aditya Toshniwal <
>> aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Hackers,
>>>
>>> Attached is the patch to fix the issue where it was not possible to add
>>> constraints, index, rules, triggers and compound triggers on child tables
>>> of a partitioned table.
>>> The problem was with URLs formed which also included parent table OID,
>>> which was not needed. The code is changed to add "url_jump_after_node"
>>> param to skip after a certain node, which will will skip all the value
>>> between jump_after_node to the last node, excluding jump_after_node and the
>>> last node. Partitioned table itself is a "table" and can be multilevel.
>>>
>>> Kindly review.
>>>
>>> --
>>> Thanks and Regards,
>>> Aditya Toshniwal
>>> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
>>> "Don't Complain about Heat, Plant a TREE"
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>>
>> *Sr. Software Architect*
>> *EnterpriseDB Software India Private Limited*
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>

--
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Aditya Toshniwal 2020-01-01 09:21:57 [pgAdmin][RM4198] Backslash as last char in constant confuses syntax highlighting
Previous Message Akshay Joshi 2020-01-01 07:39:43 pgAdmin 4 commit: Ensure that constraints, indexes, rules, triggers, an