Re: [pgAdmin4][RM#4199] ENTER in Data Filter runs query

Hi Hackers,

As per discussion, I have removed the place holder string from the dialog
and added it as a tooltip of the "OK" button.
I have added the documentation and screenshot.

Attached is the modified patch. Please review it.

On Tue, Sep 17, 2019 at 6:52 PM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:

> Attached is the modified patch to lighten the text of the place holder
> string.
>
> On Tue, Sep 17, 2019 at 6:29 PM Akshay Joshi <
> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>
>> Hi Hackers,
>>
>> Attached is the patch to fix RM 4199 "ENTER in Data Filter runs query".
>> To solve this problem I have remove the key mapping of the "OK" button,
>> which is mapped to ENTER key and provided the alternative key combination
>> that is "*SHIFT + ENTER*".
>>
>> I have added Placeholder message for that in code mirror.
>> Refer Data_Filter.png.
>> Please review it.
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>>
>> *Sr. Software Architect*
>> *EnterpriseDB Software India Private Limited*
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
>
> *Sr. Software Architect*
> *EnterpriseDB Software India Private Limited*
> *Mobile: +91 976-788-8246*
>

--
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*