Re: [pgAdmin][Patch] - Feature #6395 - Feature request: Log Rotation

Thanks, patch applied.

On Tue, May 25, 2021 at 4:59 PM Yogesh Mahajan <
yogesh(dot)mahajan(at)enterprisedb(dot)com> wrote:

> Hello,
>
> Please find the attached file incorporated with the above comments except
> the 2nd one.
>
> Thanks,
> Yogesh Mahajan
> EnterpriseDB
>
>
> On Tue, May 25, 2021 at 1:09 PM Akshay Joshi <
> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>
>> Hi Yogesh
>>
>> Following are the review comments:
>>
>> - LOG_ROTATION_MAX_LOGS should be renamed to
>> LOG_ROTATION_MAX_LOG_FILES
>> - Rollover file name should have '.log' extension at the end instead
>> of "pgadmin4.log.2021-05-25_12-17-43"
>> - Add comments in the 'enhanced_log_rotation.py' file.
>> - 'enhanced_log_rotation.py' file line no 23 should be "max_bytes =
>> max_bytes * 1024 * 1024" instead of "max_bytes = max_bytes * 1000000"
>>
>>
>> On Tue, May 25, 2021 at 10:54 AM Yogesh Mahajan <
>> yogesh(dot)mahajan(at)enterprisedb(dot)com> wrote:
>>
>>> Hi,
>>>
>>> Please find the attached patch which rotates the pgadmin log file with
>>> context to the parameters specified in the config file.
>>>
>>> # Log rotation setting
>>> LOG_ROTATION_SIZE = 10 # In MBs
>>> LOG_ROTATION_AGE = 1440 # In minutes
>>> LOG_ROTATION_MAX_LOGS = 90 # Maximum number of backups to retain
>>>
>>>
>>> Thanks,
>>> Yogesh Mahajan
>>> EnterpriseDB
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>> *pgAdmin Hacker | Principal Software Architect*
>> *EDB Postgres <http://edbpostgres.com>*
>>
>> *Mobile: +91 976-788-8246*
>>
>

--
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres <http://edbpostgres.com>*

*Mobile: +91 976-788-8246*