| From: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
|---|---|
| To: | Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [pgAdmin][SonarQube] Cognitive complexity roles + test cases |
| Date: | 2020-08-27 07:40:48 |
| Message-ID: | CANxoLDdc5Z0ZzszSUNZbNUE=K6FOKPXU8bugvpWc97wAZu7igQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Thanks, patch applied.
On Thu, Aug 27, 2020 at 12:49 PM Aditya Toshniwal <
aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
> Hi Hackers,
>
> Attached is the patch to reduce the cognitive complexity for
> validate_request function in roles module from 258 to 15. I've also added a
> few more test scenarios in the roles RE-SQL test cases to make sure the
> changes are tested.
>
> Please review.
>
> --
> Thanks,
> Aditya Toshniwal
> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
> <http://edbpostgres.com>
> "Don't Complain about Heat, Plant a TREE"
>
--
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres <http://edbpostgres.com>*
*Mobile: +91 976-788-8246*
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Akshay Joshi | 2020-08-27 07:40:59 | Re: [PATCH] Fix pgAdmin4 v4.25 ignoring user configuration. Fixes #5773 |
| Previous Message | Akshay Joshi | 2020-08-27 07:40:14 | pgAdmin 4 commit: Fixed an issue where the application ignores the fixe |