Re: [Accessibility] RM4608 Few issues in the dialogs.

From: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
To: Pradip Parkale <pradip(dot)parkale(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [Accessibility] RM4608 Few issues in the dialogs.
Date: 2020-03-19 10:51:53
Message-ID: CANxoLDdbO_=rZ0urOC0ADAEkkykyf3mLdtLUw8M4xevgjeZm3w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks, patch applied.

On Thu, Mar 19, 2020 at 2:48 PM Pradip Parkale <
pradip(dot)parkale(at)enterprisedb(dot)com> wrote:

> Hi Akshay,
> Please find the things which I have fixed in this patch.
>
> Fixed some accessibility issues:
> 1) Aria-label additions at few missing places.
> 2) Label additions with 'sr-only' class where hidden labels required.
> 3) Converted label to span to solve accessibility error.
>
> I also incorporated the review comments given by Khushboo related to
> RM4237. It was related to DateTime picker control using the keyboard.
>
> On Thu, Mar 19, 2020 at 2:32 PM Akshay Joshi <
> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>
>> Hi Pradip
>>
>> Can you please list down the things that you have fixed in this patch.
>>
>> On Thu, Mar 19, 2020 at 2:26 PM Pradip Parkale <
>> pradip(dot)parkale(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Hackers,
>>>
>>> Please find the patch for accessibility errors in some of the dialogs.
>>>
>>>
>>> --
>>> Thanks & Regards,
>>> Pradip Parkale
>>> QMG, EnterpriseDB Corporation
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>>
>> *Sr. Software Architect*
>> *EnterpriseDB Software India Private Limited*
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> Thanks & Regards,
> Pradip Parkale
> QMG, EnterpriseDB Corporation
>

--
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2020-03-19 16:56:46 pgAdmin 4 commit: Don't hard code the architecture.
Previous Message Akshay Joshi 2020-03-19 10:50:31 pgAdmin 4 commit: Fixed some accessibility issues in the dialogs: