| From: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
|---|---|
| To: | Vishal Sawale <vishal(dot)sawale(at)enterprisedb(dot)com> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [RM- 4575] RE_SQL for Schema |
| Date: | 2019-08-08 13:38:24 |
| Message-ID: | CANxoLDdZHmqPozanHujQtcdMdxhiwh-s1pguReVaq2jLYSv8HA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi Vishal
Following are my review comments:
- Test cases for Schemas are not executing at all, we need to change the
logic.
- test.json file is not aligned properly.
- Don't specify the namespaceowner/grantee/grantor as a hardcoded value
to 'enterprisedb'.
- Don't specify the hardcode value for "oid": 40970.
On Thu, Aug 8, 2019 at 4:23 PM Vishal Sawale <vishal(dot)sawale(at)enterprisedb(dot)com>
wrote:
> Hi Hackers,
>
> PFA the patch for RE-SQL test cases for Schema node. Please review.
>
> Regards,
> Vishal
>
>
>
>
--
*Thanks & Regards*
*Akshay Joshi*
*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dave Page | 2019-08-08 14:07:14 | pgAdmin 4 commit: Add support for OpenSSL 1.1.1 to the Windows installe |
| Previous Message | Aditya Toshniwal | 2019-08-08 13:17:40 | [pgAdmin] Remove hard-source-webpack-plugin |