Re: [pgAdmin][Patch] RM 5463 - CSV download quotes numeric columns

From: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
To: Yogesh Mahajan <yogesh(dot)mahajan(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin][Patch] RM 5463 - CSV download quotes numeric columns
Date: 2020-07-09 07:54:41
Message-ID: CANxoLDdYy5iTSOsOmpHvAvT5qNzu3HX7C6tmeGqhAjKm6TYaeQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Aditya

Can you please review it.

On Wed, Jul 8, 2020 at 4:17 PM Yogesh Mahajan <
yogesh(dot)mahajan(at)enterprisedb(dot)com> wrote:

> Hi,
>
> Please find a patch which fixes the issue of quoting values of
> numeric data types like 'bigint, numeric, double precision & real'.
>
> The issue was caused because global type caster are registered for
> connection in order to avoid javascript compatibility issue for large size
> data types like real, numeric, double precision, bigint.
> Typcaster used to cast these data type values into String, causing quotes
> to numeric data in downloaded CSV files in case of "CSV quoting = Strings".
>
> As part of fix, type caster is temporarily unregistered for these numeric
> data types while creating CSV file & registered back after csv file
> creation.
>
>
>
> Thanks,
> Yogesh Mahajan
> QA - Team
> EnterpriseDB Corporation
>
> Phone: +91-9741705709
>

--
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2020-07-09 07:55:26 Re: [pgAdmin][RM5569] [SQL] Bad display of tables storage parameters in the "SQL" tab (correction of bug #5398 not complete)
Previous Message Akshay Joshi 2020-07-09 07:54:17 Re: [pgAdmin4][RM#5662] [Accessibility] File manager dialog was not rendering properly due to fixed width and height set in the code