Re: [pgAdmin][Patch] RM5571 - Expression in exclusion constraint is misinterpreted and quoted as column name by mistake

From: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
To: Yogesh Mahajan <yogesh(dot)mahajan(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin][Patch] RM5571 - Expression in exclusion constraint is misinterpreted and quoted as column name by mistake
Date: 2020-07-20 10:45:55
Message-ID: CANxoLDdPgVJP2UJ6xJdQKBqW_981Jr_E5PGzRG16tjh-q6z5Ew@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Yogesh

The fix is not correct we should not remove qtIdent. What if we have a
column name like '123', 'Test Col' then your patch won't work.
Also, you have updated the "create.sql" for 11_plus folder, we should
consider all the server versions.

On Mon, Jul 20, 2020 at 3:44 PM Yogesh Mahajan <
yogesh(dot)mahajan(at)enterprisedb(dot)com> wrote:

> Hello,
>
> Please find a patch which fixes the issue about SQL tab display for
> exclusion constraint.
>
> Thanks,
> Yogesh Mahajan
> QA - Team
> EnterpriseDB Corporation
>
> Phone: +91-9741705709
>

--
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2020-07-20 10:48:47 pgAdmin 4 commit: Update version for release.
Previous Message Yogesh Mahajan 2020-07-20 10:13:57 [pgAdmin][Patch] RM5571 - Expression in exclusion constraint is misinterpreted and quoted as column name by mistake