Re: Raise an exception under Python < 3.4

From: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: pgadmin-hackers <pgadmin-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Raise an exception under Python < 3.4
Date: 2020-04-30 11:58:57
Message-ID: CANxoLDdKFL6eGQ9aCUTXFU0SkpE72sF36VtHHaCL9p_8R4P_ow@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks, patch applied.

Also, search PY2 and removed all the references by correcting the logic.

On Thu, Apr 30, 2020 at 1:45 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Hi Akshay,
>
> Sure, go for it.
>
> On Thu, Apr 30, 2020 at 9:14 AM Akshay Joshi <
> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>
>> Hi Dave
>>
>> Can we add a similar exception in our test suites? Instead of throwing
>> import error, it would be good. If you agree I'll modify the logic.
>>
>> On Mon, Apr 27, 2020 at 9:27 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>>> The attached patch raises an exception if run under Python < 3.4. It
>>> also cleans up the README to remove references to Python 2 and removes
>>> Python 2-isms from the main config.
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>>
>> *Sr. Software Architect*
>> *EnterpriseDB Software India Private Limited*
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

--
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Aditya Toshniwal 2020-04-30 13:30:28 [pgAdmin][RM5455] Cleanup pgAdmin.py
Previous Message Akshay Joshi 2020-04-30 11:56:42 Re: Remove Python 2 support from the desktop runtime