Re: RM#1387 [Add-on PATCH] Bad handling of missing connection database server

From: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: RM#1387 [Add-on PATCH] Bad handling of missing connection database server
Date: 2016-09-06 13:05:57
Message-ID: CANxoLDdF0ooA5qQo4ymjzcsSxjPEYL6nCziWOTtwC4jSnQxeWQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Code looks good to me. Patch applied.

On Tue, Sep 6, 2016 at 12:05 PM, Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com
> wrote:

>
>
> On Fri, Sep 2, 2016 at 7:49 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>> Akshay, can you review/commit this please?
>>
>
> Sure.
>
>>
>> Thanks.
>>
>> On Tue, Aug 30, 2016 at 5:05 PM, Ashesh Vashi <
>> ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
>>
>>> On Tue, Aug 30, 2016 at 7:16 PM, Ashesh Vashi <
>>> ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
>>>
>>>> Hi Dave,
>>>>
>>>> Please find the add-on patch on top of the current change.
>>>>
>>>> Can you please take a look at it?
>>>> This mainly works on the postgres driver to make an attempt to
>>>> reconnect the server.
>>>>
>>>
>>> One more attempt with some more corner cases handling.
>>> * Handled the connection-lost, and object gone error on client side
>>> during 'refresh' operation.
>>> * Handle the reconnection more consistently (even during cursor object
>>> creation).
>>>
>>> Please take a look at it.
>>>
>>> --
>>>
>>> Thanks & Regards,
>>>
>>> Ashesh Vashi
>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>>> <http://www.enterprisedb.com/>
>>>
>>>
>>> *http://www.linkedin.com/in/asheshvashi*
>>> <http://www.linkedin.com/in/asheshvashi>
>>>
>>>>
>>>> --
>>>>
>>>> Thanks & Regards,
>>>>
>>>> Ashesh Vashi
>>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>>>> <http://www.enterprisedb.com>
>>>>
>>>>
>>>> *http://www.linkedin.com/in/asheshvashi*
>>>> <http://www.linkedin.com/in/asheshvashi>
>>>>
>>>
>>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
>
> --
> *Akshay Joshi*
> *Principal Software Engineer *
>
>
>
> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>

--
*Akshay Joshi*
*Principal Software Engineer *

*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2016-09-06 13:07:36 pgAdmin 4 commit: Python 2.6 fixes. Fixes #1636. Fixes #1659
Previous Message Akshay Joshi 2016-09-06 13:04:24 pgAdmin 4 commit: Improve the logic for Bad handling of missing connect