Re: RM5576: Improve error messaging if the storage and log directories cannot be created

From: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: pgadmin-hackers <pgadmin-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: RM5576: Improve error messaging if the storage and log directories cannot be created
Date: 2020-06-02 07:00:11
Message-ID: CANxoLDdELfG+jhU8AMc7_cgB-0=AMMR2L2Z-tZNyWph157tPQA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Dave

I have tested the logic on Mac OSX but not on Windows. The "*pwd*" module
is not available on windows hence Jenkins build is failing.
Attached is the patch to fix for Windows OS. I have used the "*getpass*"
module for Windows.

Please review it. If looks good I'll commit the code.

On Tue, Jun 2, 2020 at 11:12 AM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:

> Thanks, patch applied.
>
> On Mon, Jun 1, 2020 at 9:20 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>> Patch for $SUBJECT attached. Sample output:
>>
>> python web/pgAdmin4.py
>> ERROR : Failed to create the directory /var/lib/pgadmin:
>> [Errno 13] Permission denied: '/var/lib/pgadmin'
>> HINT : Create the directory /var/lib/pgadmin, ensure it is writeable by
>> 'dpage', and try again, or, create a config_local.py file
>> and override the SQLITE_PATH setting per
>> https://www.pgadmin.org/docs/pgadmin4/4.22/config_py.html
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
>
> *Sr. Software Architect*
> *EnterpriseDB Software India Private Limited*
> *Mobile: +91 976-788-8246*
>

--
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*

Attachment Content-Type Size
RM_5576_v2.patch application/octet-stream 2.4 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Satish V 2020-06-02 07:15:16 Re: Re- [RM-3669]If user drop any object and click on create script, count rows and Truncate table, proper error should displayed that object is in present
Previous Message Khushboo Vashi 2020-06-02 06:52:50 Re: Re- [RM-3669]If user drop any object and click on create script, count rows and Truncate table, proper error should displayed that object is in present