From: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
---|---|
To: | Cyril Jouve <jv(dot)cyril(at)gmail(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: More idiomatic python3 + fix some tests |
Date: | 2020-08-31 11:18:17 |
Message-ID: | CANxoLDdCapDy6EXx9CKXr7BPJ5zbkefSCBX6HwnQDGXrZ3iX-Q@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi Cyril
Thanks, patch applied. Please make sure to run "yarn run pep8" before
sending the patch.
On Sat, Aug 29, 2020 at 2:28 AM Cyril Jouve <jv(dot)cyril(at)gmail(dot)com> wrote:
> Hello,
>
> patch 1 to 6 generated mostly using 2to3:
> 0001: https://docs.python.org/3.8/library/2to3.html#2to3fixer-asserts
> 0002: https://docs.python.org/3.8/library/2to3.html#2to3fixer-filter
> 0003: https://docs.python.org/3.8/library/2to3.html#2to3fixer-idioms
> 0004: https://docs.python.org/3.8/library/2to3.html#2to3fixer-metaclass
> 0005: https://docs.python.org/3.8/library/2to3.html#2to3fixer-xrange
> 0006: https://docs.python.org/3.8/library/2to3.html#2to3fixer-unicode
>
> patch 7 fixes change_password tests:
> Less that min length : min is 8 instead of 6
> Valid password : use an user different than admin user / mock mail module
>
> patch 8 fixes ConstraintDeleteMultipleTestCase on py3.10 (using simplejson
> like in all other modules).
>
> Regards,
> Cyril
>
--
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres <http://edbpostgres.com>*
*Mobile: +91 976-788-8246*
From | Date | Subject | |
---|---|---|---|
Next Message | Akshay Joshi | 2020-08-31 12:22:24 | pgAdmin 4 commit: Fixed an issue where --load-server does not allow loa |
Previous Message | Akshay Joshi | 2020-08-31 11:17:26 | pgAdmin 4 commit: Change the following to replace Python 2 code with Py |