Re: Reg - [sonarqube] Refactor this code so that this expression does not always evaluate to true

From: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
To: Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>
Cc: Satish V <satish(dot)v(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Reg - [sonarqube] Refactor this code so that this expression does not always evaluate to true
Date: 2020-06-15 11:21:01
Message-ID: CANxoLDdCL1ymiH+Jz_XC0MJ12e0H-PP_gKFaRn4zFVittGDr3w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks, patch applied.

On Mon, Jun 15, 2020 at 4:19 PM Aditya Toshniwal <
aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:

> Hi,
>
> The patch looks good to me.
>
> On Mon, Jun 15, 2020 at 11:20 AM Satish V <satish(dot)v(at)enterprisedb(dot)com>
> wrote:
>
>> Hi Hackers,
>>
>> Please find the patch in the attachment which clears the sonarqube error,
>> related to expressions evaluated to true/false always. Kindly review the
>> patch and share the changes required
>>
>>
>> Thanks,
>> Sathish V
>>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>

--
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2020-06-15 11:21:10 Re: Patch to contribute in pgAdmin to increase the maximum length of the server password
Previous Message Akshay Joshi 2020-06-15 11:20:15 pgAdmin 4 commit: Fix 'expressions evaluated to true/false always' issu