From: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
---|---|
To: | Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [pgAdmin 4][Patch]: #7314 - psycopg2 to psycopg3 migration |
Date: | 2022-09-01 07:31:18 |
Message-ID: | CANxoLDd5zp-wCJ3vbUx5rm=gwDOXixJOigN6x8XZp6jr1MP0wg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi Khushboo
Following are the review comments:
- Remove psycopg2 from requirements.txt
- Set PG_DEFAULT_DRIVER to psycopg3 in config.py
- Remove all the imports of 'psycopg2' from the entire project.
- Query Tool not working with psycopg3 == 3.1
On Tue, Aug 30, 2022 at 8:57 PM Khushboo Vashi <
khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
> Hello,
>
> Please find the attached patch to migrate psycopg2 to psycopg3. I have
> used psycopg v 3.1.0 which is yet to be released soon. To test the patch,
> one needs to clone the psycopg3 repo, build it and point it to the pgadmin
> venv.
>
> For the time being, psycopg2 and psycopg3 both can be configurable via PG_DEFAULT_DRIVER
> and can be used.
>
> With this patch many SQL Ascii related issues and Range partition
> related issues are resolved. For example: #7028, # 6575, #4061, #7165.
>
> I have verified some of them but we need to test all of them.
>
> Note: Debugger test cases are still failing, on which I am still working.
>
> Thanks,
> Khushboo
>
--
Akshay Joshi
Principal Software Architect
+91 9767888246
<https://www.linkedin.com/company/edbpostgres>
<https://twitter.com/edbpostgres?lang=en>
<https://www.facebook.com/EDBpostgres>
<https://www.instagram.com/EDBpostgres/>
From | Date | Subject | |
---|---|---|---|
Next Message | Yogesh Mahajan | 2022-09-02 07:20:58 | [Patch] - Bug #7580 - uwsgi + nginx db backup does not work |
Previous Message | Akshay Joshi | 2022-09-01 06:15:57 | pgAdmin 4 commit: Fixed audit issue. |