Re: [pgAdmin][patch]: Sonarqube bug fixes

From: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
To: Nikhil Mohite <nikhil(dot)mohite(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Dave Page <dpage(at)pgadmin(dot)org>
Subject: Re: [pgAdmin][patch]: Sonarqube bug fixes
Date: 2022-08-10 09:36:58
Message-ID: CANxoLDd4F09sTtJFnigSsRCTrH=90-3+ztspx9xh8kUzT_zpSQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks, the patch applied.

On Wed, Aug 10, 2022 at 2:28 PM Nikhil Mohite <
nikhil(dot)mohite(at)enterprisedb(dot)com> wrote:

> Hi Hackers,
>
> Please find the updated patch
>
> On Wed, Aug 10, 2022 at 1:40 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>> Hi
>>
>> On Wed, 10 Aug 2022 at 07:47, Nikhil Mohite <
>> nikhil(dot)mohite(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Hackers,
>>>
>>> Please find the attached patch to fix sonarqube issues.
>>>
>>
>> Can you fix the second typo here as well please?
>>
>> -import MasterPasswordContent from './MasterPassowrdContent';
>> +import MasterPasswordContent from './MasterPasswordContent';
>> import ChangePasswordContent from './ChangePassowrdContent';
>>
> I have updated it with a new patch.
>
>>
>> --
>> Dave Page
>> Blog: https://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EDB: https://www.enterprisedb.com
>>
>>
> Regards,
> Nikhil Mohite
>

--

<http://www.enterprisedb.com>

Akshay Joshi

Principal Software Architect

+91 9767888246

www.enterprisedb.com

<https://www.linkedin.com/company/edbpostgres>
<https://twitter.com/edbpostgres?lang=en>
<https://www.facebook.com/EDBpostgres>
<https://www.instagram.com/EDBpostgres/>

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2022-08-10 09:44:09 pgAdmin 4 commit: Remove unnecessary variable.
Previous Message Dave Page 2022-08-10 09:36:51 pgAdmin 4 commit: Fix additional issues detected by Sonarqube.