Re: [pgAdmin4][RM2136] Include "?<intver>" on all routes that are loaded

Thanks patch applied.

On Thu, Aug 2, 2018 at 1:07 PM, Aditya Toshniwal <
aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:

> Hi Hackers,
>
> Attached is the updated patch and includes changes suggested by Khushboo.
>
>
> On Wed, Aug 1, 2018 at 12:22 PM, Khushboo Vashi <
> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>
>> Hi Aditya,
>>
>> - Some of the svg files (connect.svg, disconnect.svg in Query Tool) are
>> left.
>>
> The problem is with image files used in
>
> css files with url param. I did not find any way in webpack to add url
> params to internal ulr's used in css. Apart from that everything is covered.
>
> - The variable name (INTERNAL_VERSION_PARAM) in the config can be renamed
>> as APP_VERSION_PARAM
>>
> This is done.
>
>
> - The value of the INTERNAL_VERSION_PARAM can be 'ver' or 'v' instead of
>> 'intver'.
>>
> Value set 'ver' for now. We can always change it later and thats why made
> it configurable.
>
>>
>> Except above the patch looks good to me.
>>
>> Thanks,
>> Khushboo
>>
>> On Thu, Jul 26, 2018 at 5:54 PM, Aditya Toshniwal <
>> aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Hackers,
>>>
>>> Attached is the patch for RM2136 which will add "?<ver_param>=<ver>" to
>>> all the static files requested and will help in cache busting on upgrading
>>> pgAdmin4.
>>> <ver_param> name is configurable and is present in
>>> config.py-INTERNAL_VERSION_PARAM.
>>> The value <ver> is taken as APP_VERSION_INT (which is updated with every
>>> release).
>>> Setting INTERNAL_VERSION_PARAM value to blank or None will disable the
>>> version param add.
>>> New parameter INTERNAL_VERSION_EXTN (tuple) is also added to specify the
>>> file extensions for which the version param to be added. I have added a few
>>> for now.
>>> Test cases included.
>>>
>>> Kindly review.
>>>
>>> --
>>> Thanks and Regards,
>>> Aditya Toshniwal
>>> Software Engineer | EnterpriseDB Software Solutions | Pune
>>> "Don't Complain about Heat, Plant a tree"
>>>
>>
>>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB Software Solutions | Pune
> "Don't Complain about Heat, Plant a tree"
>

--
*Akshay Joshi*

*Sr. Software Architect *

*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*