Re: [pgAdmin4][Patch]: Schema Diff Fixes

Thanks, patch applied.

On Tue, Jan 28, 2020 at 12:02 PM Khushboo Vashi <
khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:

> The fixes which are covered in this patch:
>
> Issues
> Version mismatch should displayed if select EPAS 11 as source and EPAS 12
> as target
> We should handle schema diff if user stop server after compare
> Data type is not visible for column headers in query tool/view data.
> Difference SQL is shown, though source & target sql are same
> Error shown when 'target only' table is selected & clicked on Generate
> Script.
> Incorrect Difference SQL is generated on comparing 2 tables having only
> different data type for a column as boolean & boolean []
> Difference SQL generated on deleting primary constraints from source
> throwing error on running from query tool
> Copy' button for 'Difference ' SQL does not work
> Incorrect SQL is generated when check constraint from source table is
> dropped.
> Difference SQL is NOT shown when 'Unique Constraint' is dropped from
> source table
> In case of difference no message displayed related to copied successfully
> or not
> create or replace trigger should be on next line
> Comparison Result of exactly identical tables having foreign key
> constraint, is shown as different. But difference SQL is NOT shown
> Wrong SQL displayed in difference tab for view and materialised view for
> select statement
> Wrong SQL displayed for procedure in difference section
> If user already open compare section of Schema diff tool and Disconnect
> the server then '<' not supported between instances of 'NoneType' and 'int'
> message displayed
> When 'check constraint' is added on source table which has already unique
> constraint & identical target table is created, all SQL panels remain empty
> Difference SQL is NOT shown when after adding 'Foreign Key' constraint to
> existing source table.
> Incorrect SQL is generated when existing index on source table is modified.
> Wrong SQL displayed for function in difference section
> Additional space is added before & after in difference SQL generated on
> addition of index to source table.
> Difference SQL is NOT shown when tables have different permission/grants
> Incorrect SQL is shown when source had inherited table & target has normal
> table.
> Exactly identical child(inherited) tables shows difference SQL
> Comparison is NOT working when custom vacuum is enabled & one of parameter
> modified & again custom vacuum is disabled
> Thanks,
> Khushboo
>
> On Tue, Jan 28, 2020 at 11:33 AM Khushboo Vashi <
> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>
>> Hi,
>>
>> Please find the attached patch to fix the Schema Diff issues.
>>
>> Thanks,
>> Khushboo
>>
>

--
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*