Re: PgAgent Patch

Hi Mehmet

I have reviewed the patch, but it is only for nix machine. Can you please
provide a patch where it should be fixed for Windows as well. I
have implemented the same in one of my project using below logic which
works for both windows and nix. You can tried out the below logic

errFile = 'xyz.txt';
FILE *fpError = freopen(errFile.mb_str(), "w", stderr); .... .... // If
output is empty then either job did not return any output // or job threw
some error into stderr. if (output == wxEmptyString) { // Check script
threw some error into stderr if (fpError) { fclose(fpError); fpError = fopen
(errFile.mb_str(), "r"); if (fpError) { char buffer [4098]; wxString
errorMsg = wxEmptyString; while (!feof(fpError)) { if (fgets(buffer, 4096,
fpError) != NULL) errorMsg += wxString(buffer, wxConvLibc); } fclose(fpError);
} } }

On Wed, Mar 4, 2015 at 10:41 AM, Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com
> wrote:

> Sure
>
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company
> <http://www.enterprisedb.com>
>
>
> *http://www.linkedin.com/in/asheshvashi*
> <http://www.linkedin.com/in/asheshvashi>
>
> On Tue, Mar 3, 2015 at 2:01 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>> Ashesh; can you please get this reviewed and applied if it looks OK?
>>
>> Thanks.
>>
>> On Tue, Mar 3, 2015 at 12:00 PM, Mehmet Emin KARAKAŞ <emin100(at)gmail(dot)com>
>> wrote:
>> > Hi,
>> > If batch cron is failed, pgagent doesn't receive error messages. We fix
>> it.
>> > We canalized the stderr to stdout. This patch batch cron receive error
>> > massages from nix machine. Git Diff Message and job.cpp file is
>> attached.
>> >
>> > Thanks.
>> >
>> > --
>> > MEHMET EMİN KARAKAŞ
>> > Postgresql Global Username: emin100
>> >
>> >
>> >
>> > diff --git a/job.cpp b/job.cpp
>> > index 00334ab..694be22 100644
>> > --- a/job.cpp
>> > +++ b/job.cpp
>> > @@ -273,8 +273,11 @@ int Job::Execute()
>> > // The *nix way.
>> > FILE *fp_script;
>> > char buf[4098];
>> > +
>> > + wxString wxSt = wxT("");
>> > + wxSt.Printf( _("%s 2>&1"), filename.c_str());
>> >
>> > - fp_script =
>> > popen(filename.mb_str(wxConvUTF8), "r");
>> > + fp_script =
>> popen(wxSt.mb_str(wxConvUTF8) ,
>> > "r");
>> > if (!fp_script)
>> > {
>> > output.Printf(_("Couldn't
>> execute
>> > script: %s, errno = %d"), filename.c_str(), errno);
>> >
>> >
>> >
>> >
>> >
>> >
>> >
>> > --
>> > Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
>> > To make changes to your subscription:
>> > http://www.postgresql.org/mailpref/pgadmin-hackers
>> >
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>>
>> --
>> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>
>
>

--
*Akshay Joshi*
*Principal Software Engineer *

*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*