| From: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
|---|---|
| To: | Rahul Shirsat <rahul(dot)shirsat(at)enterprisedb(dot)com> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: SonarQube Fixes #4 Database & Foreign Tables |
| Date: | 2021-01-21 09:17:15 |
| Message-ID: | CANxoLDcnOgBoR5yc4E3ugtmF3dT71+eHJ63RPHd0OvMnf9tE-Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi Rahul
Following are the review comments:
- Change the name of the function 'get_pg_db_properties'. The function
returns lastsysoid and datistemplate only and I assume it is applicable for
PG/EPAS both.
- Add comments for all the new functions introduce in the patch.
On Thu, Jan 21, 2021 at 2:36 PM Rahul Shirsat <
rahul(dot)shirsat(at)enterprisedb(dot)com> wrote:
> Hi Hackers,
>
> Please find the attached patch which resolves the sonar qube issues
> relating:
>
>
> 1. *Foreign Tables* -*Refactor this function to reduce its Cognitive
> Complexity from 67 to the 15 allowed.*
> 2. *Database* -*Refactor this function to reduce its Cognitive
> Complexity from 17 to the 15 allowed.*
>
>
> --
> *Rahul Shirsat*
> Senior Software Engineer | EnterpriseDB Corporation.
>
--
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres <http://edbpostgres.com>*
*Mobile: +91 976-788-8246*
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Akshay Joshi | 2021-01-21 09:22:19 | pgAdmin 4 commit: Fixed an issue where shared server entries not gettin |
| Previous Message | Rahul Shirsat | 2021-01-21 09:05:35 | SonarQube Fixes #4 Database & Foreign Tables |