From: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
---|---|
To: | Pradip Parkale <pradip(dot)parkale(at)enterprisedb(dot)com> |
Cc: | Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [pgAdmin][RM2546]: Partitioned table should be created using COLLATE and opclass. |
Date: | 2021-09-09 10:56:48 |
Message-ID: | CANxoLDcmCeuzvK6tWnSZwN+1m=SgEfxG7B1Gw48O8rA547axDw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Thanks, the patch applied.
On Wed, Sep 8, 2021 at 9:40 AM Pradip Parkale <
pradip(dot)parkale(at)enterprisedb(dot)com> wrote:
> Hi Hackers,
>
> Please find the updated patch. I have removed unnecessary code.
>
> On Tue, Sep 7, 2021 at 11:49 PM Aditya Toshniwal <
> aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
>
>> Hi Pradip,
>>
>> I can see 4 different styles for variable naming - all small, camel, all
>> caps, using underscores:
>> + this.datatypes = datatypes;
>> + this.getOperatorClass = getOperatorClass;
>> + this.dataTYPE = [];
>> + this.op_class_types = [];
>>
>> On Tue, Sep 7, 2021 at 8:41 PM Pradip Parkale <
>> pradip(dot)parkale(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Hackers,
>>>
>>> Please find the attached patch for Partitioned table should be created
>>> using COLLATE and opclass.I have added collate and opclass support for
>>> partition table.
>>>
>>> --
>>> Thanks & Regards,
>>> Pradip Parkale
>>> Software Engineer | EnterpriseDB Corporation
>>>
>>
>>
>> --
>> Thanks,
>> Aditya Toshniwal
>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
>> <http://edbpostgres.com>
>> "Don't Complain about Heat, Plant a TREE"
>>
>
>
> --
> Thanks & Regards,
> Pradip Parkale
> Software Engineer | EnterpriseDB Corporation
>
--
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres <http://edbpostgres.com>*
*Mobile: +91 976-788-8246*
From | Date | Subject | |
---|---|---|---|
Next Message | Akshay Joshi | 2021-09-09 11:00:36 | pgAdmin 4 commit: Correct the message in the release note. |
Previous Message | Akshay Joshi | 2021-09-09 10:56:30 | pgAdmin 4 commit: Added support to create the Partitioned table should |