From: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
---|---|
To: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [pgAdmin4][Patch] Add formatted error message support in psycopg2 |
Date: | 2016-03-31 07:07:40 |
Message-ID: | CANxoLDck1+6BXZvjcQ7bSfGGsnESV74-fWpkuwUsJm8Fuh9GwA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi
On Tue, Mar 29, 2016 at 8:09 PM, Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com
> wrote:
> Hi All
>
> While implementing Query Tool, I came to know we need error message's with
> some extra information and also I have faced one issue regarding
> asynchronous connection polling. I have added support for formatted error
> message and also fixed the issue.
>
> Attached is the patch file. Please review it and let me know the review
> comments if any.
>
Apart from above, today I fixed one more issue. In case of user cancel
the running transaction, poll function of psycopg2 returns
psycopg2.extensions.POLL_OK, which is mislead by the caller of the
function, so I have added one flag which will be true if user purposely
cancel the transaction and from our poll function we return new status i.e.
ASYNC_CANCEL_TRANSACTION.
Attached is the modified patch. Please review it and if it looks good
please commit it.
>
>
> --
> *Akshay Joshi*
> *Principal Software Engineer *
>
>
>
> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>
--
*Akshay Joshi*
*Principal Software Engineer *
*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
Attachment | Content-Type | Size |
---|---|---|
Psycopg_Formatted_error_v2.patch | application/octet-stream | 8.5 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Harshal Dhumal | 2016-03-31 08:04:21 | Tree reload & panel close issue after saving new node on server [pgadmin4] |
Previous Message | Murtuza Zabuawala | 2016-03-31 06:57:18 | Patch: Added select2cell editor for backgrid [pgAdmin4] |