Re: pgAdmin4 v4.11 candidate builds

From: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
To: Devrim Gündüz <devrim(at)gunduz(dot)org>
Cc: Fahar Abbas <fahar(dot)abbas(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: pgAdmin4 v4.11 candidate builds
Date: 2019-07-24 09:15:00
Message-ID: CANxoLDcj6E9JzhmNfKOUmMiESQS8MS3fioJrOESa2vSn8W1V4w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Devrim

We have figure out the problem with the syntax print("Copy rows...",
file=sys.stderr, end="") with Python 2.7.
Attached is the patch please apply, test it and let me know.

On Wed, Jul 24, 2019 at 1:25 PM Devrim Gündüz <devrim(at)gunduz(dot)org> wrote:

>
> Hi Akshay,
>
> On Wed, 2019-07-24 at 13:08 +0530, Akshay Joshi wrote:
> > No, I'll not re-wrap 4.11. I am not much aware of the RPM's, but I
> think
> > you will need to change the spec file and add "--exclude
> > feature_tests"
> > parameter to the command for regression test.
>
> I don't run regression tests in the spec file:
>
>
> https://git.postgresql.org/gitweb/?p=pgrpms.git;a=blob;f=rpm/redhat/master/pgadmin4/master/pgadmin4.spec;h=576a07420ecb250dfdc57291f1c294cb06c963f9;hb=HEAD
>
> What I basically do is:
> * cd runtime; qmake -o Makefile pgAdmin4.pro; cd ..
> * build docs
> * Manually install the files.
> * Create config_distro.py file
>
> Cheers,
> --
> Devrim Gündüz
> Open Source Solution Architect, Red Hat Certified Engineer
> Twitter: @DevrimGunduz , @DevrimGunduzTR
>

--
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*

Attachment Content-Type Size
Fix_Feature_Test_RPM.patch application/octet-stream 452 bytes

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message 2019-07-24 11:11:07 Pgadmin4 off - line installation
Previous Message Ganesh Jaybhay 2019-07-24 08:56:03 [pgAdmin][Patch] Highlight adjacent switch cell on focus in backgrid(IE11)