Re: [pgAmin4][Patch] - Kerberos support for Windows Installer

Thanks, patch applied.

On Thu, Jan 21, 2021 at 3:46 PM Khushboo Vashi <
khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:

> Hi Dave,
>
> Please find the attached updated patch.
>
> Thanks,
> Khushbo
>
> On Thu, Jan 21, 2021 at 3:17 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>> Hi
>>
>> On Thu, Jan 21, 2021 at 7:11 AM Khushboo Vashi <
>> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>>
>>> Hi,
>>>
>>> Please find the attached patch to add the Kerberos support in the
>>> Windows installer script.
>>>
>>
>> A couple of comments:
>>
>> - The file names should be in lower case in the COPY lines. It will still
>> work of course, but for consistency and style...
>>
> Fixed.
>
>> - There's no check that the environment variable is set to a valid value.
>> For others, we have code block like:
>>
>> Fixed.
>
>> IF NOT EXIST "%PGADMIN_QT_DIR%" (
>> ECHO !PGADMIN_QT_DIR! does not exist.
>> ECHO Please install Qt and set the PGADMIN_QT_DIR environment variable.
>> EXIT /B 1
>> )
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EDB: http://www.enterprisedb.com
>>
>>

--
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres <http://edbpostgres.com>*

*Mobile: +91 976-788-8246*