| From: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
|---|---|
| To: | Anthony Emengo <aemengo(at)pivotal(dot)io> |
| Cc: | Dave Page <dpage(at)pgadmin(dot)org>, Joao De Almeida Pereira <jdealmeidapereira(at)pivotal(dot)io>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [pgAdmin4][Patch] Feature #3270 Add support for running regression tests against Firefox |
| Date: | 2018-05-09 07:10:14 |
| Message-ID: | CANxoLDcgKA6Z1j8D2oT4YgBq5z8FQbrMWzC7a7ek9G740zD5=g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Thanks Anthony for fixing those two test cases. I have verified it and
patch looks good to me.
Attached is the modified patch where I have remove "import time" which is
not required and update the retry message from 10 to 60.
To be honest I have seen some intermittent "Timeout" issues on
*Chrome* and *FireFox
*and those issues are not consistent for any particular test case.
@Hackers, Please review it and if it looks good then commit it.
On Wed, May 9, 2018 at 3:58 AM, Anthony Emengo <aemengo(at)pivotal(dot)io> wrote:
> Hey, noticed that the patch above seems to fail on our CI pipelines, which
> run Chrome. Please look at this revised patch that accommodates for both
> Chrome and Firefox with the wait_for_element_to_reload function.
>
>>
--
*Akshay Joshi*
*Sr. Software Architect *
*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
| Attachment | Content-Type | Size |
|---|---|---|
| RM_3270_v9.patch | application/octet-stream | 10.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Murtuza Zabuawala | 2018-05-09 07:33:53 | [pgAdmin4] To make session cookie more secure (Server mode) |
| Previous Message | Anthony Emengo | 2018-05-08 22:28:50 | Re: [pgAdmin4][Patch] Feature #3270 Add support for running regression tests against Firefox |