Re: pgAdmin 4 - next gettext usage fixes

From: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
To: "Libor M(dot)" <liborm85(at)gmail(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: pgAdmin 4 - next gettext usage fixes
Date: 2020-04-10 09:27:35
Message-ID: CANxoLDcg=Jpkj5+16KNgAG171mz1bSF-+oFLRb_B4KAEO8Lb4w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Libor

Thanks, patch applied. Please make sure to run the PEP8 checks before
sending the patch.
I have fixed and committed the code.

On Wed, Apr 8, 2020 at 9:30 PM Libor M. <liborm85(at)gmail(dot)com> wrote:

> Hello,
> I fixed next gettext usage:
>
> - fixed gettext usage with .format() only for original text with %s
> - fixed typos
> - fixed translation yes/no buttons in dialog
> - improved translating sentences without "connecting" words (eg. see
> web/pgadmin/dashboard/static/js/dashboard.js, word 'cancel' needs to
> be translated in Czech language as 'zrušit' but in another sentence as
> 'zrušení')
> - added gettext for text translations
>
> Diff file is attached.
>
> Best regards,
>
> Libor M.
>
> E-mail: liborm85(at)gmail(dot)com
> GitHub: https://github.com/liborm85
>

--
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2020-04-10 09:42:59 Re: [pgAdmin][RM5227] Cannot add user
Previous Message Akshay Joshi 2020-04-10 09:25:30 Re: [pgAdmin4][Patch] - RM 5270 - [EPAS] Synonym properties does not show OID.