From: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
---|---|
To: | Rahul Shirsat <rahul(dot)shirsat(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [pgAdmin] [patch] RM5319 [Code Coverage] Improve API test cases for Server module |
Date: | 2021-03-30 05:46:18 |
Message-ID: | CANxoLDce-GKpLQby5oXEYBBgpJpunB-Df6gq2xjDJ-bMqmi=Zg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Thanks, patch applied.
On Wed, Mar 24, 2021 at 3:13 PM Rahul Shirsat <
rahul(dot)shirsat(at)enterprisedb(dot)com> wrote:
> Hi Akshay,
>
> Please find the updated patch which covers 75% of code coverage for Server
> mode & 68% for Desktop mode.
>
> On Wed, Mar 17, 2021 at 12:56 PM Akshay Joshi <
> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>
>> Hi Rahul
>>
>> No improvement in the coverage after applying your patch. Attached is the
>> HTML file to show which function/code not covered.
>> Please try to cover those functions/codes if possible and then send the
>> patch.
>>
>> On Tue, Mar 16, 2021 at 11:51 AM Rahul Shirsat <
>> rahul(dot)shirsat(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Hackers,
>>>
>>> Please find the patch for code coverage to improve test cases for server
>>> modules.
>>>
>>> Also a minor issue of server creation when created along with Advanced
>>> Tab setting passfile keeping auto connect disable is fixed along with this
>>> patch.
>>>
>>> --
>>> *Rahul Shirsat*
>>> Senior Software Engineer | EnterpriseDB Corporation.
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>> *pgAdmin Hacker | Principal Software Architect*
>> *EDB Postgres <http://edbpostgres.com>*
>>
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> *Rahul Shirsat*
> Senior Software Engineer | EnterpriseDB Corporation.
>
--
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres <http://edbpostgres.com>*
*Mobile: +91 976-788-8246*
From | Date | Subject | |
---|---|---|---|
Next Message | Akshay Joshi | 2021-03-30 10:54:14 | pgAdmin 4 commit: Remove the alertify error message as no need to show |
Previous Message | Akshay Joshi | 2021-03-30 05:45:31 | pgAdmin 4 commit: Improve code coverage and API test cases for Server m |