From: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
---|---|
To: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | [pgAdmin4][Patch]: Fix for Feature #4334, RM #4496 and #4497 |
Date: | 2019-07-24 07:09:47 |
Message-ID: | CANxoLDcbVUZUjQiS56g07EHaR3+5340P9QjpES2GC_JoRd5+gg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi Hackers,
I have added the support of Generated Columns (PG/EPAS 12) and also fixed
RM #4496, #4497.
During the implementation of that I have also fixed following issues that I
encountered:
- User should not be able to provide Default value with Identity column.
- 'Drop Cascade' button to delete multiple columns should be disabled.
- Set "Not Null?" switch to 'Yes' when we create Identity column.
- Fix issue when we insert default value for the column and then remove
it. It generates wrong msql.
- Fix issue when we provide the default value of a column and then
select the datatype to serial/bigserial/smallserial, it generates wrong
msql.
Modified/Added regression test cases for adding Identity column and
Generated columns.
Please review it.
--
*Thanks & Regards*
*Akshay Joshi*
*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*
Attachment | Content-Type | Size |
---|---|---|
RM_4334_4496_4497.patch | application/octet-stream | 71.2 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Devrim Gündüz | 2019-07-24 07:32:43 | Re: pgAdmin4 v4.11 candidate builds |
Previous Message | Akshay Joshi | 2019-07-24 05:18:14 | Re: pgAdmin4 v4.11 candidate builds |