| From: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
|---|---|
| To: | Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [pgAdmin4][Patch]: RM_ 2582 - Backup : Fix compression value |
| Date: | 2017-08-17 11:09:23 |
| Message-ID: | CANxoLDcaxqgbNZ37kz15=9jpP7_xqJwe7f_nNuHwA_4U6cL7wg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Thanks patch applied. I have adding server side validation too.
On Wed, Aug 16, 2017 at 6:11 PM, Surinder Kumar <
surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
> Hi
>
> *Issue:*
> In Backup, compression field can only accept values between 0 to 9. But if
> the field is clicked, an empty value is set into the model, So, added a
> check to remove the model attribute if the field is an empty string before
> data is sent to the server.
>
> Please find attached patch.
>
> Thanks,
> Surinder
>
--
*Akshay Joshi*
*Principal Software Engineer *
*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Akshay Joshi | 2017-08-17 12:24:21 | pgAdmin 4 commit: Fixed alertify notification messages where checkmark |
| Previous Message | Akshay Joshi | 2017-08-17 11:08:41 | pgAdmin 4 commit: Unset compression ratio if it is an empty string in B |