From: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
---|---|
To: | Satish V <satish(dot)v(at)enterprisedb(dot)com> |
Cc: | Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: Re- [RM-3669]If user drop any object and click on create script, count rows and Truncate table, proper error should displayed that object is in present |
Date: | 2020-06-03 05:57:44 |
Message-ID: | CANxoLDcaT_ZOLPw6oQgYrfMkVTmdUd9Vdjch8EJxjvDJPsrezw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Thanks, patch applied.
On Tue, Jun 2, 2020 at 6:36 PM Satish V <satish(dot)v(at)enterprisedb(dot)com> wrote:
> Hi Khushboo,
>
> The Reason for checking status==410 is to show error dialog to the user
> which will not go unnoticed at any situation. For closing the empty query
> tool we need this error dialog pop which shows the error message and closes
> the empty query tool for deleted nodes upon clicking ok.
>
> Changes inside the "alertify.pgadmin.defaults.js file" is made to avoid
> repeating the same patch which calls pgBrowser.report_error(which is used
> to show the error dialog message), in multiple places .
>
> Changes inside database.js file are made to make sure that the error
> message has the proper title, which was missing previously for the "connect
> database" context menu.
>
> -fixed the issues related to spacing between the operators.
>
> Please find the updated patch in the attached file.
>
> Thanks,
> Sathish V
>
> On Tue, Jun 2, 2020 at 2:40 PM Khushboo Vashi <
> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>
>> Hi Satish,
>>
>> - On failure, you have added a new condition if (e.status == 410) at
>> some places, this is not necessary as we have generalised code for that.
>> - Please maintain the consistency in messages, you can check the GONE
>> message template, we do have them at some places. (Example: on Database
>> expansion )
>> - Please follow basic JS coding standards. Ex: A space is required
>> after/before any operator. I have seen 1 or 2 places where a space is
>> missing in your patch.
>>
>> Thanks,
>> Khushboo
>>
>> On Tue, Jun 2, 2020 at 12:45 PM Satish V <satish(dot)v(at)enterprisedb(dot)com>
>> wrote:
>>
>>> Hi Kushboo,
>>>
>>> All the menus for all the deleted nodes were handled except Maintenance,
>>> backup /restore, import/export.
>>>
>>> Scripts,Refers View,View/Edit data and Create- child nodes for any
>>> parent node which is deleted are handled.
>>> Refresh, Delete/drop,drop cascade and properties were already handled
>>> for all the nodes. So i didn't make changes to them as they are displaying
>>> proper error messages already and I checked it for all the nodes.
>>>
>>>
>>> Thanks
>>> Sathish V
>>>
>>> On Tue, Jun 2, 2020 at 12:22 PM Khushboo Vashi <
>>> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>>>
>>>> Hi Satish,
>>>>
>>>> On Mon, Jun 1, 2020 at 2:16 PM Satish V <satish(dot)v(at)enterprisedb(dot)com>
>>>> wrote:
>>>>
>>>>> Hi Hackers,
>>>>>
>>>>> Attached is the patch which alerts the users when they try to consume
>>>>> the options in the context menu of the deleted node.
>>>>>
>>>> Can you please specify the context menu options which you handled, so
>>>> it will be easy for me to review.
>>>>
>>>> Thanks,
>>>> Khushboo
>>>>
>>>>> -fixed the opening of an empty query tool window for non existing
>>>>> nodes.(create/delete/update..)
>>>>> - handles the error like "list index out of range" with a reasonable
>>>>> error dialog or alert.
>>>>>
>>>>> Kindly review the patch and let me know of the changes required.
>>>>>
>>>>>
>>>>> Thanks,
>>>>> Sathish V
>>>>>
>>>>
--
*Thanks & Regards*
*Akshay Joshi*
*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*
From | Date | Subject | |
---|---|---|---|
Next Message | Satish V | 2020-06-03 07:15:46 | Re: Re- [RM-3669]If user drop any object and click on create script, count rows and Truncate table, proper error should displayed that object is in present |
Previous Message | Akshay Joshi | 2020-06-03 05:56:39 | pgAdmin 4 commit: Ensure that proper error should be displayed for the |