From: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
---|---|
To: | Rahul Shirsat <rahul(dot)shirsat(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [pgAdmin][RM3279] the Drop and Disconnect connection menupoints are too close for each others |
Date: | 2019-11-05 10:06:40 |
Message-ID: | CANxoLDcZn6timgdxUDX1Jm=usRKn2FEveF8DV=FSno3KSMuBPA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi Rahul
Following are the review comments:
- Priority should be set to 5 instead of 997, as the 'Remove Server'
menu goes very down with that priority. 'Remove Server' menu should be near
to 'Connect Server' and 'Disconnect Server'. I have tested it with 5 and it
looks fine. Refer the below screenshot
[image: Screenshot 2019-11-05 at 3.27.22
PM.png] [image: Screenshot 2019-11-05 at 3.27.38 PM.png]
- As we have renamed the menu from 'Drop Server' to 'Remove Server' we
should also change the same for the below dialog when the user clicks on
the menu:
[image: Screenshot 2019-11-05 at 3.16.55
PM.png]
- Please check the documentation as we renamed the menu, so we may need
to change the docs.
On Tue, Nov 5, 2019 at 2:48 PM Rahul Shirsat <rahul(dot)shirsat(at)enterprisedb(dot)com>
wrote:
> Hi Hackers,
>
> Attached is the patch to move "Delete/Drop" menu option away from
> "Disconnect Servers" for server node.
>
> Additionally, I have renamed the "Delete/Drop" menu option to "Remove
> Server" for server node against issue RM3859.
>
> --
> *Rahul Shirsat*
> Software Engineer | EnterpriseDB Corporation | Pune.
>
--
*Thanks & Regards*
*Akshay Joshi*
*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*
From | Date | Subject | |
---|---|---|---|
Next Message | Aditya Toshniwal | 2019-11-06 07:02:47 | [pgAdmin][RM4348] Theme options in pgAdmin and dark theme |
Previous Message | Akshay Joshi | 2019-11-05 09:18:19 | Re: [pgAdmin][RM4895] Possible issue in reset function for nested objects |