Re: [pgAdmin][RM7462]: Revisit all the SQL files and remove the SQL for all the unsupported version

From: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
To: Pradip Parkale <pradip(dot)parkale(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin][RM7462]: Revisit all the SQL files and remove the SQL for all the unsupported version
Date: 2022-08-01 16:27:22
Message-ID: CANxoLDcTuZ9Lnw2sfNHbG3DsBMt+uyBhz4BvsG50PH6PvXavpw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Pradip

The following test cases are failing on different database versions:

EPAS 12:
TriggerFuncAddTestCase (Fetch Trigger Function Node URL)
TriggerFuncGetTestCase (Fetch Trigger Function Node URL)
TriggerFuncPutTestCase (Fetch Trigger Function Node URL)
BackupJobTest (When backup the object with the default options)
RestoreJobTest (When restore the object with the default options)
TableGetTestCase (Get: Fetch multiple existing table details,
Get: Fetch non-existing table details)
SchemaSQLTestCase (Error - Get schema SQL using wrong schema id)
ReverseEngineeredSQLTestCases (Reverse Engineered SQL Test Cases)

EPAS 11, 13 and 14:
TriggerFuncAddTestCase (Fetch Trigger Function Node URL)
TriggerFuncGetTestCase (Fetch Trigger Function Node URL)
TriggerFuncPutTestCase (Fetch Trigger Function Node URL)
BackupJobTest (When backup the object with the default options)
RestoreJobTest (When restore the object with the default options)
ReverseEngineeredSQLTestCases (Reverse Engineered SQL Test Cases)

PG 13:
SearchObjectsApiSearch (Search with all types)

PG 14:
ReverseEngineeredSQLTestCases (Reverse Engineered SQL Test Cases)

PG15:
TestRoleDependenciesSql (Test Role Dependencies SQL file)

On Mon, Aug 1, 2022 at 2:58 PM Pradip Parkale <
pradip(dot)parkale(at)enterprisedb(dot)com> wrote:

> Hi Akshay,
> Please find the updated patch.
>
>
> *Thanks & Regards,*
>
> *Pradip ParkaleSoftware Engineer | EnterpriseDB Corporation*
>
>
> On Mon, Aug 1, 2022 at 2:40 PM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
> wrote:
>
>> Hi Pradip
>>
>> Can you please rebase and send the patch?
>>
>> On Thu, Jul 28, 2022 at 1:34 PM Pradip Parkale <
>> pradip(dot)parkale(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Hackers,
>>>
>>> Please find the updated patch.
>>>
>>> This Patch also includes the fix for 7481 [SQL] OWNED BY incorrectly set
>>> to NONE when adding user privileges on sequence.
>>>
>>>
>>> *Thanks & Regards,*
>>>
>>> *Pradip ParkaleSoftware Engineer | EnterpriseDB Corporation*
>>>
>>>
>>> On Wed, Jul 27, 2022 at 9:26 AM Pradip Parkale <
>>> pradip(dot)parkale(at)enterprisedb(dot)com> wrote:
>>>
>>>> Hi Hackers,
>>>>
>>>> Found one minor issue with the implementation.I will send another patch
>>>> soon.Please don't commit this patch.
>>>>
>>>> My apologies for any inconvenience caused.
>>>>
>>>>
>>>> *Thanks & Regards,*
>>>>
>>>> *Pradip ParkaleSoftware Engineer | EnterpriseDB Corporation*
>>>>
>>>>
>>>> On Tue, Jul 19, 2022 at 6:25 PM Pradip Parkale <
>>>> pradip(dot)parkale(at)enterprisedb(dot)com> wrote:
>>>>
>>>>> Hi Hackers,
>>>>>
>>>>> Please find the attached patch for #7462. Revisit all the SQL files
>>>>> and remove the SQL for all the unsupported versions.
>>>>>
>>>>> I have made the following changes:
>>>>>
>>>>> 1. Renamed the 10_plus to default and moved required files to this
>>>>> folder.
>>>>> 2. Removed all the folders below 10.
>>>>> 3. Made similar changes in resql test cases.
>>>>>
>>>>>
>>>>>
>>>>> *Thanks & Regards,*
>>>>>
>>>>> *Pradip ParkaleSoftware Engineer | EnterpriseDB Corporation*
>>>>>
>>>>
>>
>> --
>>
>> <http://www.enterprisedb.com>
>>
>> Akshay Joshi
>>
>> Principal Software Architect
>>
>> +91 9767888246
>>
>> www.enterprisedb.com
>>
>> <https://www.linkedin.com/company/edbpostgres>
>> <https://twitter.com/edbpostgres?lang=en>
>> <https://www.facebook.com/EDBpostgres>
>> <https://www.instagram.com/EDBpostgres/>
>>
>

--

<http://www.enterprisedb.com>

Akshay Joshi

Principal Software Architect

+91 9767888246

www.enterprisedb.com

<https://www.linkedin.com/company/edbpostgres>
<https://twitter.com/edbpostgres?lang=en>
<https://www.facebook.com/EDBpostgres>
<https://www.instagram.com/EDBpostgres/>

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2022-08-01 16:36:41 pgAdmin 4 commit: Fixed PEP8
Previous Message Dave Page 2022-08-01 15:17:56 pgAdmin 4 commit: Clarify config settings that may need to be re-define