| From: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
|---|---|
| To: | Nikhil Mohite <nikhil(dot)mohite(at)enterprisedb(dot)com> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: Patch for SonarQube code scan fixes |
| Date: | 2020-07-09 13:29:54 |
| Message-ID: | CANxoLDcRTbtjmC73b8S1WTiq9EnupOeBd9EMmUf9wNJ5zpApjg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Thanks, patch applied.
On Thu, Jul 9, 2020 at 4:11 PM Nikhil Mohite <nikhil(dot)mohite(at)enterprisedb(dot)com>
wrote:
> Hi Team,
>
> I have fixed some code smell issues in the SonarQube scan, PFA patch.
> Details as follows:
> 1. Table files(utils):
>
> - Refactor this function to reduce its Cognitive Complexity from 34 to
> the 15 allowed.
> - Refactor this function to reduce its Cognitive Complexity from 25 to
> the 15 allowed.
> - Refactor this function to reduce its Cognitive Complexity from 29 to
> the 15 allowed.
> - Refactor this function to reduce its Cognitive Complexity from 30 to
> the 15 allowed.
> - Refactor this function to reduce its Cognitive Complexity from 38 to
> the 15 allowed.
>
> There are few issues left from this file, I will send it in the next patch.
>
> Regards,
> Nikhil Mohite.
>
>
>
>
--
*Thanks & Regards*
*Akshay Joshi*
*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Akshay Joshi | 2020-07-09 13:30:04 | Re: [pgAdmin4][RM#5662] [Accessibility] File manager dialog was not rendering properly due to fixed width and height set in the code |
| Previous Message | Akshay Joshi | 2020-07-09 13:29:44 | Re: [pgAdmin][Patch] RM 5463 - CSV download quotes numeric columns |