From: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
---|---|
To: | Neel Patel <neel(dot)patel(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Dave Page <dave(dot)page(at)enterprisedb(dot)com> |
Subject: | Re: [pgAdmin4][runtime]: RM #2328 - Unable to launch query tool and debugger in new browser tab |
Date: | 2017-05-09 07:39:35 |
Message-ID: | CANxoLDcQV7socMUmvXxL0V-E=W9LUoYzmgoMRb-s1FyYtOzrXw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Thanks patch applied.
On Mon, May 8, 2017 at 3:21 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
> Akshay, could you review this please?
>
> Thanks.
>
> On Fri, May 5, 2017 at 11:53 AM, Neel Patel <neel(dot)patel(at)enterprisedb(dot)com>
> wrote:
>
>> Hi,
>>
>> Please find attached patch file with the fix of RM #2328 - [Runtime]:
>> Unable to launch query tool and debugger in new browser tab.
>>
>> I have used Qt 5.8 with webkit mentioned in below URL.
>>
>> https://github.com/annulen/webkit/releases
>>
>>
>> As there was a bug in QWebKit regarding "unload" event. We have raised
>> and also they have provided patch file to fix this issue. I have applied
>> the patch in linux and compile the webkit and tested the attached patch
>> with compiled webkit which is now working fine.
>>
>> Below is the link for reference regarding unload issue. They have
>> provided test webkit release for Mac in below URL but for other platform we
>> need to apply the patch and compile the webkit until they provide
>> webkit-releases for all platforms.
>>
>> https://github.com/annulen/webkit/issues/519
>>
>> Do review it and let me know in case of any issue.
>>
>> Thanks,
>> Neel Patel
>>
>>
>> --
>> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
--
*Akshay Joshi*
*Principal Software Engineer *
*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2017-05-09 08:12:28 | Re: [pgAdmin4][runtime]: RM #2328 - Unable to launch query tool and debugger in new browser tab |
Previous Message | Akshay Joshi | 2017-05-09 07:38:40 | pgAdmin 4 commit: Fixes #2328 |