From: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
---|---|
To: | Harshal Dhumal <harshal(dot)dhumal(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: Array representation and save array data from datagrid [RM2671][pgAdmin4] |
Date: | 2017-09-14 12:01:06 |
Message-ID: | CANxoLDcLvSdnqsCSjU75MywHfxs9QL5H4VhOL-p_bTOJdohwhw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi Harshal
I have reviewed your patch it looks good to me. Only one issue I have found
with char[], when I store {'a','b','c'} it gets stored and when I refreshed
it shows {',','}. Please look into this issue.
On Thu, Sep 14, 2017 at 3:54 PM, Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com
> wrote:
> It works, sorry for the noise.
>
> On Thu, Sep 14, 2017 at 3:48 PM, Akshay Joshi <
> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>
>> Harshal,
>>
>> Can you please rebase the patch, it's not applied with the latest code.
>>
>> On Tue, Sep 12, 2017 at 2:37 PM, Akshay Joshi <
>> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>>
>>>
>>>
>>> On Tue, Sep 12, 2017 at 2:34 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>>
>>>> Adding Akshay...
>>>>
>>>
>>> Sure.
>>>
>>>>
>>>> On Tue, Sep 12, 2017 at 10:04 AM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>>>
>>>>> Akshay, can you review/commit this please?
>>>>>
>>>>> On Mon, Sep 11, 2017 at 3:40 PM, Harshal Dhumal <
>>>>> harshal(dot)dhumal(at)enterprisedb(dot)com> wrote:
>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> Please find attached patch to represent array data in datagrid with
>>>>>> curly braces and
>>>>>> also allow user to save array with values like <null>, <empty
>>>>>> string>, '*""*' and "*''*"
>>>>>>
>>>>>> --
>>>>>> *Harshal Dhumal*
>>>>>> *Sr. Software Engineer*
>>>>>>
>>>>>> EnterpriseDB India: http://www.enterprisedb.com
>>>>>> The Enterprise PostgreSQL Company
>>>>>>
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Dave Page
>>>>> Blog: http://pgsnake.blogspot.com
>>>>> Twitter: @pgsnake
>>>>>
>>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>>> The Enterprise PostgreSQL Company
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> Dave Page
>>>> Blog: http://pgsnake.blogspot.com
>>>> Twitter: @pgsnake
>>>>
>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>> The Enterprise PostgreSQL Company
>>>>
>>>
>>>
>>>
>>> --
>>> *Akshay Joshi*
>>> *Principal Software Engineer *
>>>
>>>
>>>
>>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>>>
>>
>>
>>
>> --
>> *Akshay Joshi*
>> *Principal Software Engineer *
>>
>>
>>
>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>>
>
>
>
> --
> *Akshay Joshi*
> *Principal Software Engineer *
>
>
>
> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>
--
*Akshay Joshi*
*Principal Software Engineer *
*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
Attachment | Content-Type | Size |
---|---|---|
![]() |
image/png | 53.7 KB |
![]() |
image/png | 50.4 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Murtuza Zabuawala | 2017-09-14 13:26:43 | Re: pgAdmin 4 commit: Bundle fonts with pgAdmin so we have a standard set f |
Previous Message | Willy-Bas Loos | 2017-09-14 10:39:07 | Re: v2.0-rc1 not starting, runtime not building |