Re: [pgAdmin][RM5197] Accessibility issues of external packages

From: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
To: Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin][RM5197] Accessibility issues of external packages
Date: 2020-06-08 06:56:55
Message-ID: CANxoLDcKotZs7Y1M-ueEiBmZF-hvuFgasxo2u4Qg2zR4jSdi_A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks, patch applied.

On Fri, Jun 5, 2020 at 5:02 PM Aditya Toshniwal <
aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:

> Hi Hackers,
>
> Attached is the patch to update Codemirror version to latest which allows
> us to set screen reader labels on Codemirror editor. This is part of #5197.
> Please review.
>
> On Fri, Apr 3, 2020 at 5:14 PM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
> wrote:
>
>> Thanks, patch applied.
>>
>> On Thu, Apr 2, 2020 at 4:46 PM Aditya Toshniwal <
>> aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Hackers,
>>>
>>> Attached patch will replace the existing color picker -
>>> spectrum-colorpicker with @simonwep/pickr.
>>> spectrum-colorpicker has accessibility issues and is not maintained
>>> since long. @simonwep/pickr is actively maintained and the package is
>>> improving its accessibility actively.
>>>
>>> Please review.
>>>
>>> --
>>> Thanks and Regards,
>>> Aditya Toshniwal
>>> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
>>> "Don't Complain about Heat, Plant a TREE"
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>>
>> *Sr. Software Architect*
>> *EnterpriseDB Software India Private Limited*
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>

--
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2020-06-09 13:39:53 pgAdmin 4 commit: 1) Correct the typo 'pythonw.exe' should be 'python.e
Previous Message Akshay Joshi 2020-06-08 06:56:40 pgAdmin 4 commit: Update Codemirror version to the latest which allows