| From: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
|---|---|
| To: | Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [pgAdmin][SonarQube] Reduce cognitive complexity |
| Date: | 2020-07-27 11:03:21 |
| Message-ID: | CANxoLDcG44SWzoqfRsBHupgXBEa6tR5M5WaU0aGTyLWNHW_VCg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Thanks, patch applied.
On Mon, Jul 27, 2020 at 11:00 AM Aditya Toshniwal <
aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
> Hi Hackers,
>
> Please ignore the previous patch. Attached is the latest.
>
> On Mon, Jul 27, 2020 at 10:42 AM Aditya Toshniwal <
> aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
>
>> Hi Hackers,
>>
>> Attached is the patch to reduce cognitive complexity for:
>> 1) web/.../databases/schemas/views/__init__.py from 110 to the 15 allowed.
>> 2) web/.../servers/databases/casts/__init__.py from 18 to the 15 allowed.
>> 3) web/.../databases/schemas/collations/__init__.py from 16 to the 15
>> allowed.
>>
>> Please review.
>>
>> --
>> Thanks,
>> Aditya Toshniwal
>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
>> <http://edbpostgres.com>
>> "Don't Complain about Heat, Plant a TREE"
>>
>
>
> --
> Thanks,
> Aditya Toshniwal
> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
> <http://edbpostgres.com>
> "Don't Complain about Heat, Plant a TREE"
>
--
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres <http://edbpostgres.com>*
*Mobile: +91 976-788-8246*
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Akshay Joshi | 2020-07-27 11:07:56 | Re: Runtime refactoring |
| Previous Message | Akshay Joshi | 2020-07-27 11:02:58 | pgAdmin 4 commit: Fixed following SonarQube issues: |