Re: [pgAdmin][SonarQube] Complete the implementation of empty methods

From: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
To: Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin][SonarQube] Complete the implementation of empty methods
Date: 2020-07-24 06:46:32
Message-ID: CANxoLDcDqVd=En_gwXQWw=ndR3mWMhv3MVndJGGyBv5T-n7XTw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks, patch applied.

On Thu, Jul 23, 2020 at 11:41 AM Aditya Toshniwal <
aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:

> Hi Hackers,
>
> Attached is the patch to close all the 32 SonarQube issues under the rule
> - "Add a nested comment explaining why this method is empty, or complete
> the implementation."
>
> Please review.
>
> --
> Thanks,
> Aditya Toshniwal
> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
> <http://edbpostgres.com>
> "Don't Complain about Heat, Plant a TREE"
>

--
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres <http://edbpostgres.com>*

*Mobile: +91 976-788-8246*

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2020-07-24 06:46:43 Re: [pgAdmin4][Patch] - SonarQube Issues - 11 (Unused local variables should be removed)
Previous Message Akshay Joshi 2020-07-24 06:46:03 pgAdmin 4 commit: 1) Fixed cognitive complexity issues reported by Sona