[pgAdmin][RM4642] port should not be mandatory when a service is provided

From: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
To: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: [pgAdmin][RM4642] port should not be mandatory when a service is provided
Date: 2019-09-09 12:36:16
Message-ID: CANxoLDcBU3iygS=Dt4QshSXgrJ8BYkihmC2Zh+-BD=hB=2Ho8A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Hackers,

Attached is the patch to fix the RM #4642 "port should not be mandatory
when a service is provided". *Cyril Jouve* has sent the initial patch, but
that only removes the validation on GUI, when we save the server properties
without port and username backend throws an error because port and username
is *NOT NULL* columns in the server table in SQLite.

I have removed the *NOT NULL *constraint from the port and username. The
maintenance database is required as our whole connection logic is based on
that, so I have added the NOT NULL constraint for that column.

Please review it.

--
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*

Attachment Content-Type Size
RM_4642.patch application/octet-stream 7.4 KB

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2019-09-09 17:35:57 pgAdmin 4 commit: Remove copy of file that's now created on the fly.
Previous Message Akshay Joshi 2019-09-09 06:04:17 Re: Italian translation