Re: [pgAdmin4][Patch]: RM #3589 Allow user to save/download Explain plan as JPEG/SVG format

Hi Dave/Hackers

On Thu, Dec 6, 2018 at 3:16 PM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:

> Hi Dave
> On Thu, Dec 6, 2018 at 2:45 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>> Hi
>>
>> On Thu, Dec 6, 2018 at 6:51 AM Akshay Joshi <
>> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Hackers
>>>
>>> I didn't find the solution to show embedded SVG in Internet Explorer, so
>>> I have disabled the "Download" button for Internet Explorer. Added new
>>> function to get the browser name and version.
>>>
>>> Attached is the modified patch, please review it.
>>>
>>
>> Looking good. A few thoughts though:
>>
>> - Can we add tests? I'm not sure if it's feasible to just save a plan and
>> then check the contents look sane though, due to the download dialogue.
>>
>
> You are talking about feature tests. If yes then it's been difficult
> because each browser have different download dialog.
>
>>
>> - The plan isn't overly helpful without the stats. Can you think of any
>> way we can include them - e.g. is it possible to do mouseovers in pure SVG?
>> Or perhaps we need to render a number of tables below the diagram?
>>
>
> I'll try to include tooltips on mouseover in pure SVG.
>

Attached is the updated patch where I have added tooltips on
mouseover in pure SVG. I have added the *<title> *tag to solve this issue.
I have also increase the stroke-width of the lines. Please review
it.

>
>>
>>>
>>> On Mon, Dec 3, 2018 at 6:39 PM Akshay Joshi <
>>> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>>>
>>>> Hi Hackers,
>>>>
>>>> I am currently working on Feature 3589 "Allow user to save/download
>>>> Explain plan as JPEG/SVG format." I have added one download button to the
>>>> toolbar in "Explain" tab, when clicked it will download the explain plan as
>>>> a SVG file.
>>>>
>>>> To add this feature I'll have to modify the logic, so instead of
>>>> providing relative path of each plan (svg image), I have embedded the
>>>> binary data which is required to download the Explain plan.
>>>>
>>>> I have tested it on following:
>>>>
>>>> - *Chrome* (Working Fine)
>>>> - *FireFox* (Working Fine)
>>>> - *Microsoft Edge* (Working Fine)
>>>> - *Safari 10.1 and above. *'Download' attribute support is added in
>>>> 10.1
>>>> https://developer.apple.com/library/archive/releasenotes/General/WhatsNewInSafari/Articles/Safari_10_1.html
>>>> - *Internet Explorer *(Images are not rendered, shown X icon.).
>>>> Please refer attached image.
>>>>
>>>> Attached is the working patch for the above except Internet Explorer. I
>>>> have tried a lot to figure out the solution, but unable to fix the issue. *Need
>>>> help/suggestions how to fix the issue on Internet Explorer. *
>>>>
>>>> --
>>>> *Akshay Joshi*
>>>>
>>>> *Sr. Software Architect *
>>>>
>>>>
>>>>
>>>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>>>>
>>>
>>>
>>> --
>>> *Akshay Joshi*
>>>
>>> *Sr. Software Architect *
>>>
>>>
>>>
>>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
> --
> *Akshay Joshi*
>
> *Sr. Software Architect *
>
>
>
> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>

--
*Akshay Joshi*

*Sr. Software Architect *

*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*