Re: RM-4231: Dynamically size tab titles.

From: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
To: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>
Cc: Nikhil Mohite <nikhil(dot)mohite(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: RM-4231: Dynamically size tab titles.
Date: 2020-10-23 09:12:13
Message-ID: CANxoLDc3jMM4USe0AqG-pQA=_AQ1mnHx8BbwZY4NF--sLt4isA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi

On Fri, Oct 23, 2020 at 2:11 PM Murtuza Zabuawala <
murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:

> Hi,
>
>
>
> On Fri, Oct 23, 2020 at 1:23 PM Nikhil Mohite <
> nikhil(dot)mohite(at)enterprisedb(dot)com> wrote:
>
>> Hi Team,
>>
>> Regarding RM-4231: <https://redmine.postgresql.org/issues/4231>Dynamically
>> size tab titles.
>>
>> I discussed with Akshay and Aditya, on that basis,
>> we will provide a new option "Tabs Settings" under "Browser" in
>> preferences, so the user can enable or disable the dynamic tab size
>> setting. If the user changes the setting it will get applied to all already
>> opened tabs and the new tabs the user will open.
>>
>> We also discussed as we are introducing a new option "Tabs Settings" so
>> we can move all tab related setting in this section.
>> 1. Enable dynamic tab size.
>> 2. Placeholders for Query tool, View/Edit, and Debugger.
>> 3. Open in a new browser tab for Debugger, Schema diff, and Query tool.
>> (For this we can add multi-select dropdown)
>>
>
> I think these options should be module wise OR if we want to keep this
> design then have some some kind of grouping may Fieldset.?
>

"Enable dynamic tab size" belongs to all tabs (Query Tool, Debugger,
Schema diff), so it should be generic for all. For that, we will have to
create a new option "Tab Settings", and if we are creating a new option
then according to me it would be good if all tab related settings should be
in one place. With the current implementation, if the user wants to change
the setting of "Open in new browser tab" for all modules he/she will have
to set at different places. Similarly, If the user wants to change the
placeholder it will be good to have it in one place.

Initially, we thought of having a fieldset but for that will have to
check the feasibility, and definitely, it will take time.

>
>
>>
>> so the user will find all tabs related actions in the same place.
>> [image: image.png]
>>
>> Any suggestions or anything I have missed in this please let me know.
>>
>>
>> --
>> *Thanks & Regards,*
>> *Nikhil Mohite*
>> *Software Engineer.*
>> *EDB Postgres* <https://www.enterprisedb.com/>
>> *Mob.No: +91-7798364578.*
>>
>

--
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres <http://edbpostgres.com>*

*Mobile: +91 976-788-8246*

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Nikhil Mohite 2020-10-23 09:45:28 [pgAdmin][RM-4230]: Rename tab.
Previous Message Murtuza Zabuawala 2020-10-23 08:41:27 Re: RM-4231: Dynamically size tab titles.