| From: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
|---|---|
| To: | Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [pgAdmin4][Patch]: #3412 - Add support for PRIMARY KEY, FOREIGN KEY, indexes, and triggers on partitioned tables for PG 11 |
| Date: | 2018-07-25 12:31:24 |
| Message-ID: | CANxoLDc1RbqdMJ2WK9k6vN=k+=_HddYx=xkQte0OJXzZ2-=wkw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi Khushboo
Following are my initial review comments:
- Fix PEP-8 warnings.
- We should hide "Modulus" and "Remainder" columns for PG/EPAS 10 as
Hash partition is not supported in that.
- Primary key switch control on "columns" tab should be enabled for
partitioned table created on PG/EPAS 11.
- Please verify that Unique constraint are supported for PG/EPAS 11 or
not.
Will do code review tomorrow.
On Wed, Jul 25, 2018 at 4:29 PM, Khushboo Vashi <
khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
> Hi,
>
>
> Please find the attached patch for RM #3412.
>
> - Add support for PRIMARY KEY, FOREIGN KEY, indexes, and triggers on
> partitioned tables for PG 11
>
> - Add support for partitioning by HASH key.
>
>
> Thanks,
> Khushboo
>
--
*Akshay Joshi*
*Sr. Software Architect *
*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Aditya Toshniwal | 2018-07-26 12:24:27 | [pgAdmin4][RM2136] Include "?<intver>" on all routes that are loaded |
| Previous Message | Dave Page | 2018-07-25 12:11:04 | pgAdmin 4 commit: Fixed dashboard reloading even if subnodes under a da |