From: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
---|---|
To: | Satish V <satish(dot)v(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: Re-[Sonarqube]- Clumsy code |
Date: | 2020-06-18 07:18:06 |
Message-ID: | CANxoLDc0CJYrg9qcMBo791m-1eR33k8OtPWXzXB+zhkd4wZHNg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi Satish
Fixes like below will create another code smell in SonarQube:
- !(m.label == 'pg_global') should be *(m.label != 'pg_global')*
- !(_.isUndefined(index) || index == '');
- !(_.has(itemData, 'label') && itemData.label === '_RETURN');
- .....
Please fix such errors correctly and resend the patch. Make sure
functionality should work properly.
On Thu, Jun 18, 2020 at 11:27 AM Satish V <satish(dot)v(at)enterprisedb(dot)com> wrote:
> Hi Hackers,
>
> Please find the patch in the attachment which resolves below issue.
> 1.Replace this if-then-else statement by a single return statement.
>
> Kindy review and share the changes, if required
>
> Thanks,
> Sathish V
>
--
*Thanks & Regards*
*Akshay Joshi*
*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*
From | Date | Subject | |
---|---|---|---|
Next Message | Aditya Toshniwal | 2020-06-18 09:36:45 | Re: [pgAdmin][patch] Sonarqube issues tagged as redundant |
Previous Message | Yogesh Mahajan | 2020-06-18 06:40:18 | [pgAdmin4][Patch] - Issue fixes reported by SonarQube - 4 (Rule Comma operator should not be used) |