From: | Hamid Akhtar <hamid(dot)akhtar(at)gmail(dot)com> |
---|---|
To: | "Drouvot, Bertrand" <bdrouvot(at)amazon(dot)com> |
Cc: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Allow pageinspect's bt_page_stats function to return a set of rows instead of a single row |
Date: | 2022-07-25 17:21:02 |
Message-ID: | CANugjhsD7WK3vMcj_XBF2t2H_u2LhLi6=vg-8eSDV_-sPOEDHw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, 1 Jul 2022 at 13:01, Drouvot, Bertrand <bdrouvot(at)amazon(dot)com> wrote:
> Hi,
> On 6/30/22 10:24 AM, Hamid Akhtar wrote:
>
> On Mon, 27 Jun 2022 at 15:52, Bharath Rupireddy <
> bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote:
>
>> On Mon, Jun 27, 2022 at 1:40 PM Drouvot, Bertrand <bdrouvot(at)amazon(dot)com>
>> wrote:
>> >
>> > Hi,
>> >
>> > On 6/27/22 9:31 AM, Hamid Akhtar wrote:
>> >
>> >
>> > Hello Hackers,
>> >
>> > While working on one of my blogs on the B-Tree indexes, I needed to
>> look at a range of B-Tree page statistics. So the goto solution was to use
>> pageinspect. However, reviewing stats for multiple pages meant issuing
>> multiple queries.
>>
>> +1 to improve the API.
>>
> I think it makes sense too.
>
> But what about the other pageinspect's functions that also use a single
> blkno as parameter? Should not the patch also takes care of them?
>
> I've started working on that. But it's going to be a much bigger change
with a lot of code refactoring.
So, taking this one step at a time, IMHO, this patch is good to be reviewed
now.
> Regards,
>
> Bertrand
>
From | Date | Subject | |
---|---|---|---|
Next Message | Joe Conway | 2022-07-25 17:30:43 | Re: Proposal to provide the facility to set binary format output for specific OID's per session |
Previous Message | Hamid Akhtar | 2022-07-25 17:18:12 | Re: explain analyze rows=%.0f |