Re: Replace known_assigned_xids_lck by memory barrier

From: Michail Nikolaev <michail(dot)nikolaev(at)gmail(dot)com>
To: Nathan Bossart <nathandbossart(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: Replace known_assigned_xids_lck by memory barrier
Date: 2023-08-16 19:29:10
Message-ID: CANtu0ohXFhY2gq=D9cHFLfJjLrNMOGcUGR5thJCSpqweNnqbpQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hello, good question!

Thanks for your edits.

As answer: probably we need to change
"If we know that we're holding ProcArrayLock exclusively, we don't
need the read barrier."
to
"If we're removing xid, we don't need the read barrier because only
the startup process can remove and add xids to KnownAssignedXids"

Best regards,
Mikhail.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Nathan Bossart 2023-08-16 19:29:56 Re: Using defines for protocol characters
Previous Message Nathan Bossart 2023-08-16 18:32:36 Re: Replace known_assigned_xids_lck by memory barrier