Re: Issue with markers in isolation tester? Or not?

From: Michail Nikolaev <michail(dot)nikolaev(at)gmail(dot)com>
To: Noah Misch <noah(at)leadboat(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Issue with markers in isolation tester? Or not?
Date: 2025-01-15 00:39:37
Message-ID: CANtu0ogADxLyenSge53fVXQpA+h2q=Q8Zy2vVpLBR-EbxXcVng@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hello, Noah!

> I misunderstood, and I was mistaken to see this as a bug fix. The
> isolationtester is acting per its definition, and this would be a
definition
> change.

Yes, you are right, but I think it is better to clarify it somehow
because from my point of view that definition feels like logic in patched
version.
But maybe my non-native English prevents me from understanding it correctly.

In my opinion, it is better to add some clarification like "this marker
affects only other steps which were launched before this step or during its
execution".

> I'd need to review the motivating test to form my own opinion on whether
the
> new definition makes it easier to write tests.
> You could bundle this in the thread that wants this to stabilize that
thread's CI results.

I'll think about it, but currently it is stabilized using "notices"
and, you know, more changes - harder to merge :)

Also, I'll try one more time to stabilize it without "notices" - maybe I'll
get some insight.
Anyway - I'll ping you in that thread [0] (you're already in recipients) or
bring it here.

Best regards,
Mikhail.

[0]:
https://www.postgresql.org/message-id/flat/ZnoZ6GNwkJmq-gTh%40paquier.xyz#4d13f826fb1e62860cc3ae30067bd23a

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Nathan Bossart 2025-01-15 02:45:12 convert libpgport's pqsignal() to a void function
Previous Message Masahiko Sawada 2025-01-15 00:27:00 Re: Conflict detection for update_deleted in logical replication