Re: [PATCH] ltree, lquery, and ltxtquery binary protocol support

Alright, as usual life got in the way. I've attached a new version of
the patch with pgindent changes.

> What do you think about writing patch for ALTER TYPE?
I'd rather not :$

> 1) Write migration script, which directly updates pg_type.
This sounds like the best option right now, if we don't want people to
do manual migrations to ltree 1.2.
How would I best go at this?

> Travis has a small complaint:
Should be fixed!

Nino Floris

On Wed, Sep 25, 2019 at 10:31 PM Alvaro Herrera
<alvherre(at)2ndquadrant(dot)com> wrote:
>
> Hello, can you please post an updated version of this patch? Note that
> Travis has a small complaint:
>
> gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Werror=vla -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -g -O2 -Wall -Werror -fPIC -DLOWER_NODE -I. -I. -I../../src/include -I/usr/include/x86_64-linux-gnu -D_GNU_SOURCE -c -o crc32.o crc32.c
> crc32.c: In function ‘ltree_crc32_sz’:
> crc32.c:26:12: error: initialization discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
> char *p = buf;
> ^
> cc1: all warnings being treated as errors
> <builtin>: recipe for target 'crc32.o' failed
> make[4]: *** [crc32.o] Error 1
> make[4]: Leaving directory '/home/travis/build/postgresql-cfbot/postgresql/contrib/ltree'
>
> --
> Álvaro Herrera https://www.2ndQuadrant.com/
> PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services