Re: [PATCH] Add an ldapoption to disable chasing LDAP referrals

From: James Sewell <james(dot)sewell(at)lisasoft(dot)com>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Add an ldapoption to disable chasing LDAP referrals
Date: 2013-10-17 02:49:30
Message-ID: CANkGpBu-Bj4_tRSr2jPvQOG9vfzAqUnKQNus2mct5i_7H+SkdA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hey All,

I had missed these emails, sorry.

The search+bind mode issue is one of documentation location, I have fixed
it by moving the section to the applied to both list. As the patch is to do
with post-auth response this is correct.

As far as the issue when something other than 0 or 1 is set I am happy
throw an error (although this doesn't seem to be how option such as LDAPTLS
work: 1 if 1 else 0). I assume I would use the ereport() function to do
this (using the second example from this page
http://www.postgresql.org/docs/9.2/static/error-message-reporting.html)?

Cheers,
James

James Sewell,
PostgreSQL Team Lead / Solutions Architect
______________________________________

Level 2, 50 Queen St, Melbourne VIC 3000

*P *(+61) 3 8370 8000 * **W* www.lisasoft.com *F *(+61) 3 8370 8099

On Thu, Sep 19, 2013 at 12:56 AM, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:

> On 7/8/13 9:33 PM, James Sewell wrote:
> > New patch attached. I've moved from using a boolean to an enum trivalue.
>
> When ldapreferrals is set to something other than "0" or "1" exactly, it
> just ignores the option. That's not good, I think. It should probably
> be an error.
>
>

--

------------------------------
The contents of this email are confidential and may be subject to legal or
professional privilege and copyright. No representation is made that this
email is free of viruses or other defects. If you have received this
communication in error, you may not copy or distribute any part of it or
otherwise disclose its contents to anyone. Please advise the sender of your
incorrect receipt of this correspondence.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2013-10-17 03:27:05 Re: Patch for reserved connections for replication users
Previous Message Peter Eisentraut 2013-10-17 02:29:19 Re: psql tab completion for updatable foreign tables